mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> davidedmundson wrote in main.qml:23
> this is either unused or wrong
he's using qqc1 tooltips, they should be ported as well.
> davidedmundson wrote in main.qml:37
> Saying the size hint is the size it currently is looks wrong
>
> generally speaking:
>
> width propagates from parent to child
> implicitWidth propagates from child to parent
and what those sizehint properties are used for at all? they look wrong,
you either have implicitwidth/height or Layout.minimum/preferred/maximumwidth
and height.
implementing yourself hints should generally never be done as it will break
very easily
> main.qml:285
> +
> + ToolTip {
> + text: i18n("Cursor moves the same distance as finger.")
i guess this is the thing that comes from styles 1.4
there is also a qqc2 ToolTip element, which is the one that should be used
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D13573
To: furkantokac, romangg, ngraham, #plasma, mart
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol
