mart added inline comments.
INLINE COMMENTS
> main.qml:27
> +import org.kde.kirigami 2.4 as Kirigami
> import org.kde.plasma.core 2.0 as PlasmaCore
>
never import anything from plasma in a kcm (an exception which we have to solve
is SortFilterProxyModel)
Kirigami has its own units
> main.qml:199
> +
> + implicitWidth: units.gridUnit * 9
> +
Kirigami.Units.gridUnit
(tough controls shouldn't have explicit widths set)
> main.qml:220
> +
> + Controls.ExclusiveGroup {
> + id: accelProfile
radiobuttons are auto exclusive now
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D13372
To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol
