ngraham added inline comments.
INLINE COMMENTS
> kcm.cpp:133
> +// If yes, setNeedsSave(true).
> +void KCMWorkspaceOptions::handleIfNeedSave()
> +{
How about `handleNeedsSave()` instead?
> furkantokac wrote in ToolTip.qml:2
> Yeap it's Roman's implementation used in "input" kcm. Shouldn't I use it ?
If this code is used in multiple KCMs, we shouldn't duplicate it; we should
upstream it so that it only needs to exist in one place at a time.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D12936
To: furkantokac, romangg, ngraham
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart