mmazur added inline comments. INLINE COMMENTS
> mmazur wrote in TimerView.qml:56 > I wasn't aware that Date().getTime() wasn't in UTC. I can change it to a UTC > call if there is one. > > I'm aware of the sleep behavior change, however I do not know how to handle > it. (I was hoping the reviewer wouldn't notice.) If there's a trivial way to > bind to signals for 'system is suspending'/'system just woke up', then I can > pause the timer on those signals. > > What I cannot do is rewrite the code to use QSomethingOrOther, since I don't > know Qt and I'm not going to learn Qt. > > Just so we're on the same page – nobody cared about this plasmoid for a few > years now. To the extent that it plain stopped working when I upgraded to > ubuntu 18.04 due to bug 381173. I fixed it the way I knew how and I'm happy > with my code, since I can now use the plasmoid. > > If you have a perfect solution in mind, then you either need to code it > yourself or find someone else who will. As far as interacting with me goes, > it's either merge my code with minor improvements here and there (I can do > the sleep handling if there's a signal for it) or don't and have the thing > not work. > > If it's the former, please tell me upfront, so we don't waste each other's > time on further discussions. Latter, if it's the latter. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12536 To: mmazur, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
