fvogt added a comment.
I gave it a quick test - works fine with ssh(-add). I didn't test anything
else though.
Code-wise it looks ok (as ok as the old code...), just a remark about the
reference parameters.
INLINE COMMENTS
> main.cpp:44
> // has no i18n, so this should work for all languages as long as the string
> is unchanged.
> -static void parsePrompt(const QString &prompt, QString& keyFile, bool&
> wrongPassphrase)
> +static void parsePrompt(const QString &prompt, QString& identifier, bool&
> ignoreWallet, bool& clearText, bool& confirm)
> {
I'd prefer an enum instead of two booleans.
REPOSITORY
R105 KDE SSH Password Dialog
REVISION DETAIL
https://phabricator.kde.org/D9875
To: pali, fvogt
Cc: fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
