cfeck added a comment.
Otherwise looks good. Maybe needs more feedback from testers.
INLINE COMMENTS
> kiconloader.cpp:1264
> {
> +return loadIcon(_name, group, 1.0 /*scale*/, size, state, overlays,
> path_store, canReturnNull);
> +}
indent
> kicontheme.cpp:169
> + } else if (scale > 2.1) {
> + integerScale = 3;
> + }
Unless the XDG spec forbids this, please add scale 4, too. Those 8K screens are
everywhere ;)
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D6313
To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck,
davidedmundson, plasma-devel, #frameworks, ragreen, michaelh, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
