hein marked 5 inline comments as done.
hein added inline comments.

INLINE COMMENTS

> mart wrote in InlineMessage.qml:91
> this would make opacity of contentitem 1.0 even when animationg to 0?

No, because of `enabled: !root.visible`. implicitHeight is bound to an 
expression that's recomputed when visible has changed, and returns 0 when 
visible is false. That means by the time the Behavior would kick off in 
response to the implicitHeight property changing, it's already disabled. In 
other words, under the only condition when implicitHeights goes to 0, this 
Behavior is known to be disabled and the ScriptAction will not run.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: davidedmundson, ngraham, broulik, plasma-devel, apol, mart, hein

Reply via email to