kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.
Cannot test at the moment, but looks straight forward, so no objection from
me.
Besides the unrelated changes, they want to have their own commits :)
INLINE COMMENTS
> main.qml:24
> import org.kde.plasma.core 2.0 as PlasmaCore
> -import org.kde.plasma.private.fifteenpuzzle 0.1
> +import org.kde.plasma.private.fifteenpuzzle 0.1 as Private
>
Unrelated?
> fifteenpuzzleplugin.cpp:32
> Q_ASSERT(QLatin1String(uri) ==
> QLatin1String("org.kde.plasma.private.fifteenpuzzle"));
> - qmlRegisterTypeNotAvailable(uri, 0, 1, "fifteenpuzzle",
> QStringLiteral("fifteenpuzzle"));
> + qmlRegisterTypeNotAvailable(uri, 0, 1, "FifteenPuzzle",
> QStringLiteral("fifteenpuzzle"));
> }
Unrelated?
REPOSITORY
R114 Plasma Addons
BRANCH
phab/bundle
REVISION DETAIL
https://phabricator.kde.org/D11516
To: mart, #plasma, kossebau
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
