mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed.
I'm ok with it, tough i would change a bit the logic, as described INLINE COMMENTS > OverlaySheet.qml:117 > + */ > + property bool showCloseButton: true > + property alias showCloseButton: closeIcon.visible > OverlaySheet.qml:304 > z: 3 > - visible: !Settings.isMobile > + visible: !Settings.isMobile && showCloseButton > width: Units.iconSizes.smallMedium with the alias then we again have only: visible: !Settings.isMobile in this case, the default behavior of showCloseButton will be !Settings.isMobile, and then the developer could always override the behavior, breaking the binding to fore it always true or always false (so the property will work even on mobile) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11197 To: ngraham, mart, #kirigami Cc: plasma-devel, apol, davidedmundson, mart, hein
