mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
minor style stuff, otherwise lgtm, esp. if it works now
INLINE COMMENTS
> README:5
>
> -[Drkonqi]
> +[DrKonqi]
> ShowDebugButton=true
could be a separate commit
> debuggerlaunchers.cpp:42
> {
> - if ( qobject_cast<DebuggerManager*>(parent())->debuggerIsRunning() ) {
> + if ( static_cast<DebuggerManager*>(parent())->debuggerIsRunning() ) {
> qWarning() << "Another debugger is already running";
could be a separate commit
> debuggerlaunchers.h:81
> public:
> - explicit DBusOldInterfaceLauncher(DebuggerManager *parent = nullptr);
> + explicit DBusInterfaceLauncher(const QString& name,
> DBusInterfaceAdaptor* parent = nullptr);
> QString name() const override;
here and below: style issues, afaik & and * should be next to the var name in
frameworks code, like done in Qt
REPOSITORY
R871 DrKonqi
BRANCH
kdevelopdbus
REVISION DETAIL
https://phabricator.kde.org/D10195
To: croick, #kdevelop, #plasma_workspaces, mwolff
Cc: mwolff, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
