davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
I'm 100% convinced Plasma needs to multiply it as it does everything in
device pixels.
However:
void FrameSvgItem::updateDevicePixelRatio()
m_frameSvg->setScaleFactor(qMax<qreal>(1.0,
floor(Units::instance().devicePixelRatio())));
this changes elementSize
So with this code and that we're doing it twice. You're right one of them
should die.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/dropdevicepixelratiowq!
REVISION DETAIL
https://phabricator.kde.org/D9286
To: mart, #plasma, davidedmundson
Cc: hein, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
