apol added a comment.
Looks good, some nitpicking.
INLINE COMMENTS
> appearancegtk3.cpp:46
> + QStringList gtk3SubdirPattern{QStringLiteral("gtk-3.*")};
> + for(QFileInfoList::iterator it=availableThemes.begin();
> it!=availableThemes.end(); ++it) {
> + QDir themeDir(it->filePath());
constBegin/constEnd
> appearancegtk3.cpp:49
> + themeDir.setNameFilters(gtk3SubdirPattern);
> + if(!themeDir.entryList(QDir::Dirs).isEmpty())
> themes += it->filePath();
The name filters can be the first argument here
REPOSITORY
R99 KDE Gtk Configuration Tool
REVISION DETAIL
https://phabricator.kde.org/D9459
To: fvogt, #plasma, lbeltrame, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
