davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Works with my awesome firework wallpaper from 2 years ago.
INLINE COMMENTS
> containmentconfigview.cpp:126
> + for (const KPluginMetaData &m :
> KPackage::PackageLoader::self()->listPackages("Plasma/Wallpaper")) {
> + KPackage::Package pkg =
> KPackage::PackageLoader::self()->loadPackage("Plasma/Wallpaper",
> m.pluginId());
> +
> m_wallpaperConfigModel->appendCategory(pkg.metadata().iconName(),
> pkg.metadata().name(), pkg.fileUrl("ui",
> QStringLiteral("config.qml")).toString(), m.pluginId());
the old code has an if !package.valid {continue}
do we need that?
REPOSITORY
R120 Plasma Workspace
BRANCH
phab/fileurlwallpaper
REVISION DETAIL
https://phabricator.kde.org/D9237
To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
