apol added inline comments.
INLINE COMMENTS
> kcm.cpp:69
> +
> + m_haveThemeExplorerInstalled =
> KService::serviceByDesktopName(QStringLiteral("org.kde.plasma.themeexplorer"));
> }
Wouldn't it be better to just do
`QStandardPaths::findExecutable("plasmathemeexplorer")`? This way we don't need
a new dependency
> kcm.cpp:257
> +{
> + KRun::runCommand(QStringLiteral("plasmathemeexplorer -t ") % theme,
> nullptr);
> +}
QProcess?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8006
To: davidedmundson, #plasma
Cc: apol, abetts, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, sebas, mart
