mwolff added a comment.
small nits, plus the asserts from the previous review. otherwise lgtm - the
plasma people should chime in
INLINE COMMENTS
> foldermodel.cpp:1314
> + const QUrl url = item.url();
> + const int screen = m_screenMapper->screenForUrl(url);
> + // don't do anything if the folderview is not associated with a
> screen
double spaces after =
> foldermodel.cpp:1678
> + m_screenMapper = screenMapper;
> + if (m_screenMapper) {
> + connect(m_screenMapper, &ScreenMapper::screensChanged, this,
> &FolderModel::invalidateFilter);
remove {, you don't use them above either
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson,
apol
Cc: ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
