mlaurent added inline comments.
INLINE COMMENTS
> folderplugin_private_export.h:1
> +#ifndef FOLDERPLUGIN_PRIVATE_EXPORT_H
> +#define FOLDERPLUGIN_PRIVATE_EXPORT_H
Missing copyright
> foldermodeltest.cpp:1
> +#include "foldermodeltest.h"
> +#include "foldermodel.h"
Missing copyright
> foldermodeltest.cpp:87
> + QCOMPARE(index.data(FolderModel::FileNameRole).toString(),
> + QString("file%1.txt").arg(i + 1));
> + }
QStringLiteral(...).arg
> foldermodeltest.cpp:102
> + QCOMPARE(index.data(FolderModel::FileNameRole).toString(),
> + QString("file%1.txt").arg(i + 1));
> + }
QStringLiteral(...).arg(...)
> foldermodeltest.cpp:132
> + QTest::addColumn<QString>("name");
> + QTest::newRow("Folder rename") << 0 << "firstDirRenamed";
> + QTest::newRow("File rename") << 1 << "file1.pdf";
QStringLiteral("...) same for other line
> foldermodeltest.h:1
> +#ifndef FOLDERMODELTEST_H
> +#define FOLDERMODELTEST_H
missing copyright
> positionertest.cpp:1
> +#include "positionertest.h"
> +
copyright
> positionertest.cpp:53
> + delete m_folderModel;
> + m_folderModel = 0;
> + delete m_positioner;
nullptr;
> positionertest.cpp:55
> + delete m_positioner;
> + m_positioner = 0;
> +}
nullptr;
> positionertest.h:1
> +#ifndef POSITIONERTEST_H
> +#define POSITIONERTEST_H
missing copyright
REVISION DETAIL
https://phabricator.kde.org/D8447
To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot,
renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
