davidedmundson added inline comments.
INLINE COMMENTS
> SidebarMode.cpp:525
> + if (fe->reason() == Qt::TabFocusReason) {
> +
> qqw->rootObject()->metaObject()->invokeMethod(qqw->rootObject(),
> "focusFirstChild");
> + } else if (fe->reason() == Qt::BacktabFocusReason) {
either rootObject()->metaObject()->method("")->invoke();
or
QMetaObject::invoke()
getting the right object to call a static method on isn't worth it.
> IntroIcon.qml:41
> + Keys.onTabPressed: {
> + if (index < 4) {
> + event.accepted = false;
why 4?
Is this the item.children count?
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D8221
To: mart, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
