davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> contrast.cpp:63
> + [this] {
> + net_wm_contrast_region =
> effects->announceSupportProperty(s_contrastAtomName, this);
> + }
we should only announce this
if ((shader && shader->isValid())
> blur.cpp:78
> + [this] {
> + net_wm_blur_region =
> effects->announceSupportProperty(s_blurAtomName, this);
> + }
same here.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7761
To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart