graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> mart wrote in shell_client.cpp:608-609
> the close is actually beaing done at line 244: at the pongReceived (if the
> ping reason was closewindow, then it closes it there)
That logic I don't understand: why do we ping to close? Why a roundtrip to the
app, when all we want to do is close it? Just send it a close?
> shell_client.cpp:894-898
> + if (m_xdgShellSurface && rules()->checkAcceptFocus(wantsInput())) {
> + const qint32 pingSerial = static_cast<XdgShellInterface
> *>(m_xdgShellSurface->global())->ping(m_xdgShellSurface);
> + m_pingSerials.insert(pingSerial, FocusWindow);
> setActive(true);
> }
This breaks the existing code: the setActive(true) is now only done for xdg
shell surfaces, not for wl_shell surfaces.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D6591
To: davidedmundson, #plasma, graesslin, mart
Cc: mart, graesslin, kwin, plasma-devel, #kwin, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol
