davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> abstract_egl_backend.cpp:235
> }
> -
> - if (ctx == EGL_NO_CONTEXT && haveRobustness && haveCreateContext) {
> - const int attribs[] = {
> - EGL_CONTEXT_FLAGS_KHR,
> EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR,
> - EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY_KHR,
> EGL_LOSE_CONTEXT_ON_RESET_KHR,
> - EGL_NONE
> - };
> - ctx = eglCreateContext(m_display, config(), EGL_NO_CONTEXT,
> attribs);
> + if (haveRobustness) {
> + auto robust =
> std::unique_ptr<AbstractOpenGLContextAttributeBuilder>(new
> EglContextAttributeBuilder);
this is different from line 252 on the original, which additionally checks
hasCreateContext
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D6396
To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
