Zren added inline comments. INLINE COMMENTS
> anthonyfieroni wrote in FolderView.qml:538 > Why it used (6 * units.smallSpacing) it makes more space at bottom? It should > be same as iconwidth calculation, about me. I see you not change it, but it > should. Fairly certain was `smallSpacing * 2` + `iconSize` + `smallSpacing * 2` + `defaultFont.height * lines` + `smallSpacing * 2` Right now: - `frame` has `y: root.useListViewMode ? 0 : units.smallSpacing` - `frame` has `height: (icon.height + (2 * units.smallSpacing) + (label.lineCount * theme.mSize(theme.defaultFont).height) + (3 * units.smallSpacing));` - `icon` has `topMargin: (2 * units.smallSpacing)` - `label` has `anchors.topMargin: units.smallSpacing` So it's actually: smallSpacing | frame | smallSpacing*2 | icon | smallSpacing | text | smallSpacing*2 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6188 To: Zren, hein Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
