vitali planned changes to this revision.
vitali added inline comments.
INLINE COMMENTS
> natgeoprovider.cpp:61
> +
> +
> re.setPattern("^<meta\\s+property=\"og:image\"\\s+content=\"(.*)\".*/>$");
> +
An alternative regex may be
`"^<meta\\s.*property=\"og:image\"\\s.*content=\"(.*)\".*/>$"`, so to match any
possible future fields before `property`, and between `property` and `content`.
> sebas wrote in natgeoprovider.cpp:96
> Why this change? Moving away from https to http seems backward...
The versions with https or without the trailing slash were not working for me,
so I changed it to that one, but it could as well be just be my mistake.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D5729
To: vitali, sebas
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, lukas
