dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land.
Looks OK. It would be good to port this away from kdelibs4support though, to avoid propagating that dependency on users of the lib -- making it impossible to remove later. At least it should be removed as a public dependency (in the target_link_libraries line and from KioArchiveConfig.cmake.in). REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D5112 To: marten, #plasma, dfaure Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
