subdiff added inline comments.
INLINE COMMENTS
> authenticator.h:63
> public:
> - explicit KCheckPass(const QString &password, QObject *parent = nullptr);
> + enum class AuthenticationMode {
> + Delayed,
Can we only use the enum class in Authenticator, instead of duplicating it here?
> kcheckpass.c:394
> + }
> + if (uid != geteuid()) {
> + // we don't support multiple auth for setuid kcheckpass
Shouldn't we test this before we write the result to the socket (and then write
an error as result)?
REVISION DETAIL
https://phabricator.kde.org/D4997
To: graesslin, #plasma
Cc: subdiff, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
