elvisangelaccio added inline comments.
INLINE COMMENTS
> arichardson wrote in kdeplatformfiledialoghelper.cpp:365-370
> I want the version of Qt not KCoreAddons so that won't work.
> Do we really need a runtime Qt version check? We link to Qt5PlatformSupport,
> is that API stable or do we need to recompile for new Qt versions anyway?
What about `if (qVersion() < QStringLiteral("5.7.1")) {}`? It doesn't work in
the general case but it should work for this specific check.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D4193
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: arichardson, #plasma
Cc: elvisangelaccio, graesslin, plasma-devel, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol
