----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/#review102428 -----------------------------------------------------------
Could you please add screenshots of the new feature? This is important for us to review the visual impact your patch has. Thanks already for your work on this! I think it's a useful addition. - Sebastian Kügler On Feb. 5, 2017, 6:11 p.m., Pascal VITOUX wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129917/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2017, 6:11 p.m.) > > > Review request for kde-workspace and Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and > 'cache/writeback' infos from ksysguard 5.9.0 > > The monitor displays the dirty + writeback amount proportionaly scaled with > the maximal amount reached, until the remaining dirty amount goes below a > minimal threshold of 10MB. > > An interesting usecase is to show the real progress of a datas transfer to a > slow storage device like a USB drive. > > > Diffs > ----- > > applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa > applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 > applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b > applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 > > Diff: https://git.reviewboard.kde.org/r/129917/diff/ > > > Testing > ------- > > I use it since several months without issue. > > > Thanks, > > Pascal VITOUX > >
