dfaure accepted this revision.
dfaure added inline comments.

INLINE COMMENTS

> kdeplatformfiledialoghelper.cpp:365
> +
> +    // Qt 5 at least until 5.7.0 does not derive the directory from the 
> passed url
> +    // and set the initialDirectory option accordingly, also not for known 
> schemes

Should say 5.8.0, the autotest fails for me (without the fix) with current Qt 
5.8 git.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  fixFileDialogDirectoryWithSelectUrl

REVISION DETAIL
  https://phabricator.kde.org/D3796

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks, #plasma, graesslin, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Reply via email to