> On Дек. 21, 2016, 2:58 преди обяд, David Edmundson wrote: > > applets/taskmanager/package/contents/ui/GroupDialog.qml, line 37 > > <https://git.reviewboard.kde.org/r/128038/diff/6/?file=487005#file487005line37> > > > > note we've moved to phabricator for review requests, which is why this > > got ignored. > > Though this was still unexcusable on our side for not commenting in 6 > > months. > > > > Why are you multiplying anything by devicePixelRatio in this ? > > The logic is saying "don't be more than a 3rd of the screen width". > > > > > > Also, to match the comment in the TODO this should be > > Screen.desktopAvailableWidth
About me, 640 is exactly 1920/3 in TODO. If you think this should be property int preferredWidth: Screen.desktopAvailableWidth / (3 * Screen.devicePixelRatio) property int preferredHeight: Screen.desktopAvailableHeight / (2 * Screen.devicePixelRatio) i will committed. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128038/#review101527 ----------------------------------------------------------- On Дек. 16, 2016, 6:38 преди обяд, Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128038/ > ----------------------------------------------------------- > > (Updated Дек. 16, 2016, 6:38 преди обяд) > > > Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Eike Hein. > > > Repository: plasma-desktop > > > Description > ------- > > 1. Enable highlighted window, tooltips and grouping > 2. Open group item tasl by clicking left mouse button > 3. Move mouse cursor over item in group > > Before: > 1. Items are samll and tough readable > 2. Items aren't visible cause a highligthWindow effect > 3. Clicking on tooltip close button case highlightWindow effect to not stop > > After: > 1. Items are proof readable > 2. Items are visible > 3. HighlightWdindow effect is stopped > > > Diffs > ----- > > applets/taskmanager/package/contents/ui/GroupDialog.qml 829fcf0 > applets/taskmanager/package/contents/ui/Task.qml 0a59d53 > applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml e3551df > applets/taskmanager/package/contents/ui/main.qml e53b194 > applets/taskmanager/plugin/backend.h a3788b0 > applets/taskmanager/plugin/backend.cpp 4ef5b88 > > Diff: https://git.reviewboard.kde.org/r/128038/diff/ > > > Testing > ------- > > Screenshot with expected behavior by clicking left button on group item. > > > File Attachments > ---------------- > > Vertical panel > > https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/35dd438c-fae2-4daa-ba30-09f70ea3b920__Screenshot_20161203_210914.png > Horizontal panel > > https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/fe7c9cab-bb2a-4d17-85de-1934c81a33dc__Screenshot_20161203_211120.png > > > Thanks, > > Anthony Fieroni > >
