broulik added a comment.
LGTM overall
"Prototype of redesigned taskbar" made me curious ;)
INLINE COMMENTS
> playercontainer.cpp:123
> + int secondaryInstancePid = -1;
> + int lastPoint = m_dbusAddress.lastIndexOf(".");
> + QString end = m_dbusAddress.right(m_dbusAddress.length() - (lastPoint +
> 1));
QLatin1Char?
> playercontainer.cpp:124
> + int lastPoint = m_dbusAddress.lastIndexOf(".");
> + QString end = m_dbusAddress.right(m_dbusAddress.length() - (lastPoint +
> 1));
> + const QString pre = "instance";
Can you use rightRef and the like, if possible?
> playercontainer.cpp:128
> + end.remove(0, pre.length());
> + bool convertSuccess;
> + int i = end.toInt(&convertSuccess);
bool ok;
is sufficient in that context imho
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3667
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas
