broulik retitled this revision from "WIP: [Icon Widget] Bring back properties dialog" to "[Icon Widget] Bring back properties dialog". broulik updated the test plan for this revision. broulik updated this revision to Diff 8967. broulik added a comment.
- Ensure Link desktop file is actually .desktop so the properties dialog offers to change the URL - Emit jump list actions changed when they do (fixes jump list actions not working when applet is created for the first time) - Call sync() on the KDesktopFile we created for the file Links so the applet works when it is created for the first time for a file - KIO::suggestName always appends suffix, so check whether the file exists before - use new KRun to run the apps and QProcess::startDetached as suggested by David F - Cleanup a bit, at least try to ;) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2687?vs=6501&id=8967 REVISION DETAIL https://phabricator.kde.org/D2687 AFFECTED FILES applets/icon/CMakeLists.txt applets/icon/iconapplet.cpp applets/icon/iconapplet.h applets/icon/package/contents/config/main.xml applets/icon/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, dfaure Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
