graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> scene_qpainter_test.cpp:199
> + using namespace KWayland::Client;
> + QVERIFY(Test::setupWaylandConnection(s_socketName,
> Test::AdditionalWaylandInterface::Seat));
> + QVERIFY(Test::waitForWaylandPointer());
you don't need to do the Test::setupWaylandConnection in the test, that's part
of the init()
> scene_qpainter_test.cpp:202-203
> + QScopedPointer<Surface> s(Test::createSurface());
> + QScopedPointer<QObject>
> ss(Test::createShellSurface(Test::ShellSurfaceType::WlShell, s.data()));
> + QScopedPointer<Pointer> p(Test::waylandSeat()->createPointer());
> +
the idea of the Test::createShellSurface variant returning a QObject is to have
a test_data() with the two supported modes, so that we test both WlShell and
XdgShellUnstableV5. You can compare with other tests.
If you want to only test WlShell there is a simplified setup method returning a
ShellSurface instead of QObject.
> scene_qpainter_test.cpp:230-231
> +
> + referenceImage.save("/tmp/expected.png");
> + scene->backend()->buffer()->save("/tmp/actual.png");
> + QCOMPARE(referenceImage, *scene->backend()->buffer());
why are you saving to the tmp directory?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3495
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
