broulik added inline comments.
INLINE COMMENTS
> discretegpu_helper_actions.actions:3
> +Name=KDE
> +Name[ar]=كدي
> +Name[ast]=KDE
You can drop all those localized ones, this will be (should be?) taken care of
by scripty
> discretegpuhelper.h:32
> +public:
> + DiscreteGpuHelper(QObject *parent = nullptr);
> +
explicit
> powerdevilbackendinterface.cpp:33
> Private() : acAdapterState(UnknownAcAdapterState),
> batteryState(NoBatteryState), batteryRemainingTime(0),
> - isReady(false), isError(false), isLidClosed(false),
> isLidPresent(false) {}
> + hasDualGpu(false), isReady(false), isError(false),
> isLidClosed(false), isLidPresent(false) {}
> ~Private() {}
Why do we have it both in Core and the backendinterface?
REPOSITORY
rPOWERDEVIL Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D3451
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jgrulich, broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
