----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129096/#review99781 -----------------------------------------------------------
Ship it! Ship It! - Ivan Čukić On Oct. 4, 2016, 3:16 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129096/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2016, 3:16 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Commit 752626ad550552232d73d8b009db62b0f8e86113 left a code path through > the switch statement where defaultActionsCfg would be an invalid group. > > This is semantically correct as there is no relevant actions config for > this type of containment, however we then call methods on that config group > which leads to an assert - and a failing unit test. > > > Diffs > ----- > > src/plasma/containment.cpp dde5dd366d56147ca3d24badb17a8639c833285b > > Diff: https://git.reviewboard.kde.org/r/129096/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
