> On Aug. 16, 2016, 7:11 vorm., David Faure wrote: > > Can you move it to kde-baseapps, along with any other konqueror-related > > docbook? > > Burkhard Lück wrote: > move khtml-behavior, bookmarks, html-java-js, khtml-adblock, history, > performance, kcmcss, filemanager, khtml-general preserving history > from plasma-desktop to kde-baseapps does not make sense, because these > docbooks have no history in plasma-desktop besides the initial commit > > https://quickgit.kde.org/?p=plasma-desktop.git&a=commit&h=d64d589db1291fc61935585019f492943ce0032a > and the history before this commit is hidden and not easy to access. > > From my pov these docbook dirs should be copied from kde-runtime (with > history) into the directory kde-runtime/doc/kcontrol/ > and these dirs should be deleted afterwards in plasma-desktop > > Burkhard Lück wrote: > - From my pov these docbook dirs should be copied from kde-runtime (with > history) into the directory kde-runtime/doc/kcontrol/ > - and these dirs should be deleted afterwards in plasma-desktop > > + From my pov these docbook dirs should be copied from kde-runtime (with > history) into the directory kde-baseapps/doc/kcontrol/ > + and these dirs should be deleted afterwards in plasma-desktop
see https://git.reviewboard.kde.org/r/128803/ - Burkhard ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128685/#review98410 ----------------------------------------------------------- On Aug. 15, 2016, 11:48 vorm., Burkhard Lück wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128685/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 11:48 vorm.) > > > Review request for Documentation, KDE Base Apps, Plasma, and David Faure. > > > Repository: plasma-desktop > > > Description > ------- > > proofread + update > remove obsolete comment > > code in kde-baseapps - docbook in plasma-desktop? > > > Diffs > ----- > > doc/kcontrol/performance/index.docbook 5ac5055 > > Diff: https://git.reviewboard.kde.org/r/128685/diff/ > > > Testing > ------- > > passes checkXML5 > > > Thanks, > > Burkhard Lück > >