hein added inline comments.
INLINE COMMENTS
> abstracttasksmodel.h:119
> + * Requests to open the given URLs with the application backing the task
> + * at the given index
> + *
Missing period, also elsewhere
> abstracttasksmodel.h:121
> + *
> + * The base implementation does nothing.
> + *
s/The/This/
> abstracttasksmodel.h:124
> + * @param index An index in this tasks model.
> + * @param urls The URLs to be passed to the application
> + **/
Missing period, also elsewhere
> concatenatetasksproxymodel.h:72
> + *
> + * The base implementation does nothing.
> + *
Remove
> flattentaskgroupsproxymodel.h:75
> + *
> + * The base implementation does nothing.
> + *
Remove
> launchertasksmodel.cpp:324
> +#if HAVE_X11
> + if (QX11Info::isPlatformX11()) {
> + timeStamp = QX11Info::appUserTime();
Use KWindowSystem::isPlatformX11()
> taskfilterproxymodel.h:254
> + *
> + * The base implementation does nothing.
> + *
Remove
> taskgroupingproxymodel.h:218
> + *
> + * The base implementation does nothing.
> + *
Remove
> tasksmodel.h:583
> + *
> + * The base implementation does nothing.
> + *
Remove
> waylandtasksmodel.cpp:386
> +
> + KWayland::Client::PlasmaWindow *window = d->windows.at(index.row());
> +
const
> xwindowtasksmodel.cpp:955
> + const QUrl &url = d->appData(d->windows.at(index.row())).url;
> + KService::Ptr service =
> KService::serviceByDesktopPath(url.toLocalFile());
> + if (service) {
const I think
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2391
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: hein, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
