shumski added inline comments.

INLINE COMMENTS

> CMakeLists.txt:135
>  
> -install(TARGETS kded_powerdevil DESTINATION ${PLUGIN_INSTALL_DIR}/kf5/kded)
> +install(TARGETS powerdevil DESTINATION ${CMAKE_INSTALL_FULL_LIBEXECDIR_KF5})
> +install(FILES ${CMAKE_CURRENT_BINARY_DIR}/powerdevil.desktop

PowerDevil isn't a Framework, so this var is wrong.

> powerdevil.desktop.cmake:1
>  [Desktop Entry]
>  Type=Service

Maybe autostart for this should be limited to Plasma only?

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2372

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, broulik, graesslin
Cc: shumski, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Reply via email to