> On Авг. 3, 2016, 5:50 след обяд, Anthony Fieroni wrote: > > src/platforms/xcb/kwindowsystem.cpp, line 500 > > <https://git.reviewboard.kde.org/r/128576/diff/1/?file=472755#file472755line500> > > > > This line must be > > if (s_d && wasCompositing != s_d->compositingEnable) { > > Martin Gräßlin wrote: > why do you think so?
Mistake, d must be setted with sure. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128576/#review98056 ----------------------------------------------------------- On Авг. 3, 2016, 12:34 след обяд, Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128576/ > ----------------------------------------------------------- > > (Updated Авг. 3, 2016, 12:34 след обяд) > > > Review request for KDE Frameworks and Plasma. > > > Bugs: 362531 > https://bugs.kde.org/show_bug.cgi?id=362531 > > > Repository: kwindowsystem > > > Description > ------- > > The Xcb implementation of KWindowSystem has two operations modes and when > switching between the two it recreates the NETEventFilter. > > This could result in the compositingChanged signal never to be emitted if: > 1) NETEventFilter gets created before compositor is started > 2) NETEventFilter gets recreated after compositor is started but before > the old filter had a chance to process the XFixes event > > This was the cause for e.g. plasmashell not properly detecting that a > Compositor is running on X11. > > This change ensures that the signal is emitted if the compositing state > differs after the recreation. Also a test case is added which simulates > the condition. > > BUG: 362531 > > > Diffs > ----- > > autotests/CMakeLists.txt 690c41bfe2ca981d206c590c3fbd28416d4ae401 > autotests/compositingenabled_test.cpp PRE-CREATION > src/platforms/xcb/kwindowsystem.cpp > fbff381b61116c6eef47d5c7fa1fc5730857328c > > Diff: https://git.reviewboard.kde.org/r/128576/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
