----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128590/ -----------------------------------------------------------
(Updated Aug. 3, 2016, 1:03 p.m.) Review request for KDE Frameworks, Plasma, Matthias Klumpp, and Harald Sitter. Changes ------- Addressed marco's comments, including the port to QXmlStreamWriter. Reads much better. :) Repository: kpackage Description ------- We want our components to be exposed on software using Appstream (such as Discover, but not exclusively). Some of the most hidden components we have nowadays are Plasma addons, since they're not documented there. This attempts to fix this by reusing the metadata we already have and turning it into files that appstream can consume, without having to write yet another time the plugin metadata. This is done in 2 steps: * Introduces `kpackagetool5 --appstream-metainfo` argument * The cmake macro will automatically grab the file and process it. See: https://git.reviewboard.kde.org/r/128579/ Diffs (updated) ----- KF5PackageMacros.cmake 9163de9 autotests/CMakeLists.txt c84379d autotests/data/testfallbackpackage/testfallbackpackage.appdata.xml PRE-CREATION autotests/data/testjsonmetadatapackage/testjsonmetadatapackage.appdata.xml PRE-CREATION autotests/data/testpackage/testpackage.appdata.xml PRE-CREATION autotests/kpackagetoolappstreamtest.cmake PRE-CREATION src/kpackagetool/kpackagetool.h dc056c6 src/kpackagetool/kpackagetool.cpp 2758f70 src/kpackagetool/main.cpp a8eb5ab Diff: https://git.reviewboard.kde.org/r/128590/diff/ Testing ------- Tests pass, everything else still compiles (including r128579), we get quite some metadata. `appstreamcli validate` doesn't choke on output files. Thanks, Aleix Pol Gonzalez
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
