> On Июнь 24, 2016, 2:52 п.п., Andrey Bondrov wrote: > > Looks like this plasmoid doesn't accept keyboard shortcuts. Testing done: > > 1. KF 5.23.0 > > 2. Plasma 5.6.5 > > 3. MiminizeAll applet latest snapshot from github (May 31, 2016) > > 4. ShowDesktop applet from Plasma 5.6.5. > > > > I added MinimizeAll abd ShowDesktop applets to panel and assigned different > > keyboard shortcuts to them. ShowDesktop works via shortcut while > > MinimizeAll doesn't. > > Kai Uwe Broulik wrote: > That is because it doesn't handle Plasmoid.onActivated - this signal is > emitted when the user presses the assigned global shortcut. > > > Plasmoid.onActivated: activate() > > should do the trick > > Andrey Bondrov wrote: > Anthony, can you please add this to the code review (but first check if > it works)? > > Anthony Fieroni wrote: > It's not handle because Kwin has own keyboard shortcut for hat, it will > be confused, about me. > http://oi66.tinypic.com/i3b778.jpg > > Kai Uwe Broulik wrote: > That shortcut is only there if you enable the Minimize All KWin script > and doesn't change the fact that the applet code as of now does not react to > shortcuts.
BTW, I confirm that adding "Plasmoid.onActivated: activate()" makes assigned keyboard shortcut work. My patch: https://abf.rosalinux.ru/import/plasma5-applet-minimizeall/raw/rosa2014.1/plasma5-applet-minimizeall-20160531-accept-keyboard-shortcuts.patch - Andrey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127651/#review96844 ----------------------------------------------------------- On Апрель 28, 2016, 8:11 д.п., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127651/ > ----------------------------------------------------------- > > (Updated Апрель 28, 2016, 8:11 д.п.) > > > Review request for Plasma, KDE Usability, Martin Gräßlin, and Sebastian > Kügler. > > > Repository: kdeplasma-addons > > > Description > ------- > > ^^ > > > Diffs > ----- > > applets/CMakeLists.txt e591c81 > applets/minimizeall/CMakeLists.txt PRE-CREATION > applets/minimizeall/Messages.sh PRE-CREATION > applets/minimizeall/package/contents/config/main.xml PRE-CREATION > applets/minimizeall/package/contents/ui/main.qml PRE-CREATION > applets/minimizeall/package/metadata.desktop PRE-CREATION > applets/minimizeall/plugin/minimizeall.h PRE-CREATION > applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION > applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION > applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION > applets/minimizeall/plugin/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127651/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Screenshot_20160428_110625.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/2dc7f4c9-c10a-4166-95d7-67418ad9ce7f__Screenshot_20160428_110625.png > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
