ivan added a comment.
Mostly looks ok, though I can not comment on wayland-specific things.
INLINE COMMENTS
> splashapp.cpp:155
> +{
> + if
> (!QGuiApplication::platformName().startsWith(QLatin1String("wayland"),
> Qt::CaseInsensitive)) {
> + return;
Maybe it would be a good idea to add this as a static method to KWayland
somwehere?
> splashwindow.cpp:151
> + }
> + if (SplashApp *a = qobject_cast<SplashApp*>(qApp)) {
> + using namespace KWayland::Client;
Can this be done differently - the splash is also used as a part of StartActive
which is not a SplashApp?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2242
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #plasma
Cc: ivan, plasma-devel, jensreuterberg, abetts, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
