mart added inline comments.
INLINE COMMENTS
> ContextIcon.qml:29
> height: Units.iconSizes.smallMedium
> - property real morph: root.position
> + property real morph: 0
> property color color: Theme.textColor
does the context menu icon keeps morphing correctly with this?
> PageRow.qml:326
>
> - if (itemX >= contentX && itemX + mainFlickable.currentItem.width
> <= contentX + mainFlickable.width) {
> + if (itemX >= contentX && mainFlickable.currentItem && itemX +
> mainFlickable.currentItem.width <= contentX + mainFlickable.width) {
> return;
why adding check over mainFlickable.currentItem ? doesn't guard anything
REPOSITORY
rKIRIGAMI Kirigami
REVISION DETAIL
https://phabricator.kde.org/D2144
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #kirigami, mart
Cc: plasma-devel
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
