broulik accepted this revision. broulik added a reviewer: broulik. broulik added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > maximize_test.cpp:141 > #define CLEANUP(name) \ > if (name) { \ > delete name; \ Not related to this patch but delete nullptr is totally fine and if it's a dangling pointer the check won't help you anyway. REPOSITORY rKWIN KWin BRANCH decoration-pass-maximized-signal REVISION DETAIL https://phabricator.kde.org/D1805 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, broulik Cc: broulik, plasma-devel, kwin, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel