> On June 15, 2016, 9:16 a.m., Burkhard Lück wrote:
> > applets/systemmonitor/cpu/contents/ui/cpu.qml, line 43
> > <https://git.reviewboard.kde.org/r/128136/diff/1/?file=468085#file468085line43>
> >
> > please add context and explain what %1 and %2 are
>
> Andreas Kainz wrote:
> I really don't know.
like this: i18nc("A message to translators", "The text to translate");
i18nc("CPU usage: %1 is the value, %2 the unit datatype", "%1 %2");
useful for if some language randomly swaps things around.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128136/#review96515
-----------------------------------------------------------
On June 9, 2016, 11:58 a.m., Andreas Kainz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128136/
> -----------------------------------------------------------
>
> (Updated June 9, 2016, 11:58 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> 1. change the minimum size and the min width in the panel
> 2. speedLabels are now right align to the label cause you show the number
> which is drown on the right part of the diagramm
> 3. round to 14 % instead of 14,14 % for cpu load
>
> still missing:
> a. hide the heading if the desktop widget has to less space for the rows
> b. better friendlyName for ram, network
> c. remove the gray line from the chart (0-line) at least when the applet was
> shown on the panel
> d. don't show 0 KB/s or 0 B, ...
>
> shedule
> thanks for your review
> if you know how I can fix one of the missing things, let me know
> tiny improvements when missing stuff is finished.
>
>
> Diffs
> -----
>
> applets/systemmonitor/common/contents/ui/Applet.qml fffd8e0
> applets/systemmonitor/common/contents/ui/DoublePlotter.qml 738ffbc
> applets/systemmonitor/common/contents/ui/SinglePlotter.qml 987fd2c
> applets/systemmonitor/cpu/contents/ui/cpu.qml 4ebbf92
>
> Diff: https://git.reviewboard.kde.org/r/128136/diff/
>
>
> Testing
> -------
>
> on the desktop and the panel
>
>
> Thanks,
>
> Andreas Kainz
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
