> On June 8, 2016, 12:11 a.m., Friedrich W. H. Kossebau wrote: > > applets/weather/package/contents/ui/main.qml, lines 117-118 > > <https://git.reviewboard.kde.org/r/128108/diff/3/?file=467958#file467958line117> > > > > There is still "units.Spacing" set for the bottomMargin, which will > > yield 0. So if you want to set 0 here for both margins, best set that > > explicitely (not sure what the default is): > > ``` > > topMargin: 0 > > bottomMargin: 0 > > ``` > > > > Hm, having both top and bottom margin 0 now looks a little bit dense to > > me. But well, if you prefer that, okay.
use the comment from marco - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/#review96287 ----------------------------------------------------------- On June 7, 2016, 11:46 a.m., Andreas Kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128108/ > ----------------------------------------------------------- > > (Updated June 7, 2016, 11:46 a.m.) > > > Review request for Plasma and Friedrich W. H. Kossebau. > > > Repository: kdeplasma-addons > > > Description > ------- > > the scaling work now better and the pading between the single lines can be > smaler (If you make the applet higher you can also have the old line spacing) > > it's my first qml change, so ... > > on my todo, I'd like to change the powerd by weather.com text color so a > secondary gray (bring it a bit more to the background), but I don't know how. > > > Diffs > ----- > > applets/weather/package/contents/ui/TopPanel.qml 1821f16 > applets/weather/package/contents/ui/WeatherListView.qml c7b331e > applets/weather/package/contents/ui/main.qml d490728 > > Diff: https://git.reviewboard.kde.org/r/128108/diff/ > > > Testing > ------- > > with breeze and breeze dark color scheme on two different pc's. the icons are > breeze weather icons (master) > > > File Attachments > ---------------- > > screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/350136df-37c8-4fef-bddb-d4b609df2fb1__weather.png > I hope I had fixed all open issues. I now have only one open issue I could > change the linkColor but I can't change the color when there is no link like > in noaa > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/3ef83b18-d8e3-4a73-a8da-a069c56a560a__weather.png > > > Thanks, > > Andreas Kainz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
