----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128097/#review96200 -----------------------------------------------------------
First of all, as for any visual changes: Please provide before/after screenshots so that designers can do visual reviews. Second: I am strictly against making this an option. Either it's an improvement, then it should always be like that, or it isn't an improvement, than it should be dropped. We should not offer a config option for every tine tweak, it just overcomplicates our config UIs for little gain. This is not something so fundamental that that some users _need_ it while others _can't stand it_. So: The VDG will decide - after we've seen screenshots - whether checked menu items should use a checkmark or not, but making this an option will never get a "ship it" from the usability side. - Thomas Pfeiffer On June 4, 2016, 7:53 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128097/ > ----------------------------------------------------------- > > (Updated June 4, 2016, 7:53 p.m.) > > > Review request for KDE Software on Mac OS X, Plasma and Yichao Yu. > > > Repository: qtcurve > > > Description > ------- > > This introduces an option (hidden for now) to adorn checked menu items with > only a check mark rather than the same widget that is used for checkboxes or > radio buttons (for sets of mutually exclusive menu items). > > Initially I implemented this by simply skipping the widget "box" and drawing > only the checkbox tick for both kinds of menu items (cf. > https://bugs.kde.org/show_bug.cgi?id=363895). I then realised that this looks > weird when the user uses a very tall or tiny font (or has a high DPI screen). > Therefore the check is now generated using the UniCode `Check Mark` glyph (? > cf. http://www.fileformat.info/info/unicode/char/2713/index.htm) rendered in > the menu font (or `Apple Symbols`, on OS X). > > A new member is introduced in the `Options` structure that controls this new > behaviour. Its value is read from and written to the config file, but I have > not yet implemented its UI control through the configuration interface. I'll > want some guidance for that step. > > I propose to make this the default behaviour on OS X, so that popup menus can > be closer in appearance to the native menus from the toplevel menubar (those > menus are not rendered through Qt, and use a single check mark too). > > The GTk2 style already rendered checked menu items like this so I did not > change anything there (and don't really plan to touch that code at all). > > > Diffs > ----- > > gtk2/common/common.h cb0ec87 > gtk2/common/config_file.cpp 96936e2 > qt4/common/common.h 313db33 > qt4/common/config_file.cpp c58ad1a > qt4/style/qtcurve.cpp 951ec1a > qt5/common/common.h bb103fd > qt5/common/config_file.cpp 362381a > qt5/style/qtcurve_api.cpp b8535da > qt5/style/qtcurve_primitive.cpp a8a2bed > > Diff: https://git.reviewboard.kde.org/r/128097/diff/ > > > Testing > ------- > > On OS X 10.9 and Linux with Qt 4.8.7 and Qt 5.6.0 . > > > Thanks, > > René J.V. Bertin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
