xuetianweng added inline comments. INLINE COMMENTS
> graesslin wrote in main_wayland.cpp:449 > I don't understand the concern. The QT_IM_MODULE env variable set here in the > code only affects KWin. It is not passed to any other process. > > Setting QT_IM_MODULE env variables will still overwrite everything - except > in KWin where the variable is pointless. So nothing changes except by default > KWin can now offer a virtual keyboard. Ah, ok, I misunderstood that this will inherit by session since I thought kwin start the script exit-with-session. But then I still have one minor concern, for any window that actually inside kwin (e.g. right click on title bar -> window specific settings), the input method will be forced to qtvirtualkeyboard. Though I know input method is not commonly being used there, but I don't think that's expected behavior for input method user. REPOSITORY rKWIN KWin BRANCH virtual-keyboard REVISION DETAIL https://phabricator.kde.org/D1638 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, sebas Cc: xuetianweng, sebas, mart, broulik, plasma-devel
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel