----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128052/#review96008 -----------------------------------------------------------
Good job! File Attachment: Agenda view - after - Agenda view - after <https://git.reviewboard.kde.org//r/128052/#fcomment584> What's that? File Attachment: Agenda view - after - Agenda view - after <https://git.reviewboard.kde.org//r/128052/#fcomment585> Not sure about vertically aligning this File Attachment: Agenda view - after - Agenda view - after <https://git.reviewboard.kde.org//r/128052/#fcomment586> I can haz multiple colors? applets/digital-clock/package/contents/ui/CalendarView.qml (line 168) <https://git.reviewboard.kde.org/r/128052/#comment64939> comment that this is 24hrs (in ms?) applets/digital-clock/package/contents/ui/CalendarView.qml (line 197) <https://git.reviewboard.kde.org/r/128052/#comment64940> id as first property applets/digital-clock/package/contents/ui/CalendarView.qml (line 205) <https://git.reviewboard.kde.org/r/128052/#comment64942> I think that's the default applets/digital-clock/package/contents/ui/CalendarView.qml (line 208) <https://git.reviewboard.kde.org/r/128052/#comment64941> avoid hardcoded pixel sizes, either (ab)use units.smallSpacing or multiple with units.devicePixelRatio applets/digital-clock/package/contents/ui/CalendarView.qml (line 209) <https://git.reviewboard.kde.org/r/128052/#comment64943> Isn't Layout.fillHeight sufficient? applets/digital-clock/package/contents/ui/CalendarView.qml (line 214) <https://git.reviewboard.kde.org/r/128052/#comment64944> startDateLabel applets/digital-clock/package/contents/ui/CalendarView.qml (line 216) <https://git.reviewboard.kde.org/r/128052/#comment64945> readonly property applets/digital-clock/package/contents/ui/CalendarView.qml (line 222) <https://git.reviewboard.kde.org/r/128052/#comment64946> i18nc("Denotes event ends on a later date", "...") applets/digital-clock/package/contents/ui/CalendarView.qml (line 248) <https://git.reviewboard.kde.org/r/128052/#comment64947> font.bold: true applets/digital-clock/package/contents/ui/CalendarView.qml (line 266) <https://git.reviewboard.kde.org/r/128052/#comment64948> visible: text !== "" - Kai Uwe Broulik On Mai 29, 2016, 10:14 nachm., Daniel Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128052/ > ----------------------------------------------------------- > > (Updated Mai 29, 2016, 10:14 nachm.) > > > Review request for Plasma, Martin Klapetek and Thomas Pfeiffer. > > > Repository: plasma-workspace > > > Description > ------- > > I've been working on CalendarEventsPlugin for the digital-clock applet to > show events from Akonadi, but it turned out the agenda view in the applet is > not really ready to show real-world events yet, so I played around with it > for a while this evening...it's nothing fancy, but at least I feel like I can > use the agenda view productively now. See screenshots below. > > > Diffs > ----- > > applets/digital-clock/package/contents/ui/CalendarView.qml fb30c6f > > Diff: https://git.reviewboard.kde.org/r/128052/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Agenda view - before > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/583a3955-76bc-4e3b-8bc2-053c269acf22__calendar-before.png > Agenda view - after > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/316644c5-4184-4b6c-bf5f-a86cf25fa5db__calendar1.png > Agenda view - after > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/810cb0db-5844-486f-bee9-722a0299e943__calendar2.png > Agenda view - before > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/e73f7249-4ed3-4283-94d2-e92e412262b3__calendar-before.png > Agenda view - after > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/966381cf-4a0b-4adc-a68b-ddb9110a9527__calendar1.png > Agenda view - after > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/64ddc24b-be06-405e-88f6-868a4bf0f687__calendar2.png > > > Thanks, > > Daniel Vrátil > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
