sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS

> debug_console.cpp:135
> +    if (!device) {
> +        return tableRow(i18n("Input Device"), i18nc("The input device for 
> the event is not known", "Unknown"));
> +    }

input device *of* this event ?

> debug_console.cpp:147
>              ret.append(buttonToString(Qt::MouseButton(uint(buttons) & i)));
>              ret.append(QStringLiteral(" "));
>          }

also gets appended to the last element, so we end up with a trailing space

REPOSITORY
  rKWIN KWin

BRANCH
  debug-console-device

REVISION DETAIL
  https://phabricator.kde.org/D1668

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: sebas, plasma-devel
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to