broulik accepted this revision.
broulik added a reviewer: broulik.
broulik added a comment.
This revision is now accepted and ready to land.


  Please put the wrapping/spacing stuff into a separate commit. Thanks!

INLINE COMMENTS

> CalendarView.qml:153
>              }
> +            flickableItem.boundsBehavior: Flickable.StopAtBounds;
>  

no semicolon

> CalendarView.qml:157
> +                id: holidaysList
> +                anchors.fill: parent
>  

I don't think this is needed

> CalendarView.qml:196
> +                        wrapMode: Text.Wrap
> +                        verticalAlignment: Text.AlignTop
>                      }

Isn't this the default?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  calendar-scrollview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D1678

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, broulik
Cc: broulik, plasma-devel, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to