drosca added inline comments.

INLINE COMMENTS
> mart wrote in HolidaysConfig.qml:84
> shouldn't be onCheckedChanged, as this can happen by keyboard as well?

It can't be checked by keyboard, because there is nothing connected to the 
`toggleCurrent` signal that is emitted when pressing space.
Also if I change it to `onCheckedChanged` then there is a binding loop.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1651

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, mck182, mart
Cc: mart, plasma-devel, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to